-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
DOC: Remove makePanel from docs (#25609) #25612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Remove makePanel from docs (#25609) #25612
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25612 +/- ##
===========================================
- Coverage 91.26% 41.71% -49.56%
===========================================
Files 173 173
Lines 52968 52968
===========================================
- Hits 48339 22093 -26246
- Misses 4629 30875 +26246
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25612 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 173 173
Lines 52968 52968
=======================================
Hits 48339 48339
Misses 4629 4629
Continue to review full report at Codecov.
|
I've converted all the old whatsnew entries to code-blocks using what was in the stable docs. I did not do that for the 'Deprecate Panel' section in dsintro, if you would like me to do it there as well just let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General approach lgtm though you have some lint failures in CI - could you take a look?
I've fixed the linting errors. I did have to add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @jreback
thanks @ArtificialQualia |
git diff upstream/master -u -- "*.py" | flake8 --diff
As described in #25609, I removed the tm.makePanel() calls from the docs, along with some of the surrounding sections (a few "Deprecate Panel" sections). I did not replace these calls with an equivalent manual creation of a Panel.
If desired, I could create a panel manually in the docs with something like this:
but this PR is currently as requested in the issue with the sections removed.